[LLVM/CG] Sort PrimFuncs when creating LLVM module #8958
Merged
+76
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kparzysz-quic
requested review from
junrushao,
masahi,
tqchen,
vinx13 and
ZihengJiang
as code owners
|
cc: @jroesch @tkonolige |
PrimFuncs are stored in a map where the order of iteration is not deterministic. This can cause a different llvm::Module to be created each time, which can defeat debugging tools like -opt-bisect-limit. Add function CodeGenLLVM::AddFunctionsOrdered that takes a range of PrimFuncs or objects convertible to PrimFuncs, and adds them to the LLVM module in a deterministic order.
|
also cc @vinx13 @ZihengJiang @masahi |
|
Do you think it would be possible to add a test that the functions are in sorted order? |
kparzysz-quic
requested review from
areusch,
comaniac,
jroesch,
merrymercy and
yzhliu
as code owners
tqchen
approved these changes
Sep 8, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* [LLVM/CG] Sort PrimFuncs when creating LLVM module PrimFuncs are stored in a map where the order of iteration is not deterministic. This can cause a different llvm::Module to be created each time, which can defeat debugging tools like -opt-bisect-limit. Add function CodeGenLLVM::AddFunctionsOrdered that takes a range of PrimFuncs or objects convertible to PrimFuncs, and adds them to the LLVM module in a deterministic order. * Empty commit to restart build * Add testcase
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* [LLVM/CG] Sort PrimFuncs when creating LLVM module PrimFuncs are stored in a map where the order of iteration is not deterministic. This can cause a different llvm::Module to be created each time, which can defeat debugging tools like -opt-bisect-limit. Add function CodeGenLLVM::AddFunctionsOrdered that takes a range of PrimFuncs or objects convertible to PrimFuncs, and adds them to the LLVM module in a deterministic order. * Empty commit to restart build * Add testcase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrimFuncs are stored in a map where the order of iteration is not deterministic. This can cause a different
llvm::Moduleto be created each time, which can defeat debugging tools like-opt-bisect-limit.Add function
CodeGenLLVM::AddFunctionsOrderedthat takes a range of PrimFuncs or objects convertible to PrimFunc, and adds them to the LLVM module in a deterministic order.